feat: Implement docker configuration for mita #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enfein
requested changes
Oct 26, 2024
There was a problem hiding this comment.
You can follow the project layout from https://github.com/golang-standards/project-layout/tree/master/deployments and move the files to deployments/docker/mita-amd64 directory.
| @@ -0,0 +1,16 @@ | |||
| services: | |||
| meiru: | |||
There was a problem hiding this comment.
service, image and container_name should be mita
|
|
||
| RUN go mod tidy | ||
|
|
||
| RUN GOOS=linux GOARCH=amd64 CGO_ENABLED=0 GOCC=musl-gcc go build -ldflags="-s -w" -o mita cmd/mita/mita.go |
There was a problem hiding this comment.
The GOCC=musl-gcc have no effect and should be removed, because we have CGO_ENABLED=0, which means there is no C compiler needed and C library linked. Please help to check if the program still runs after it is removed.
|
|
||
| WORKDIR /build | ||
|
|
||
| RUN go mod tidy |
There was a problem hiding this comment.
This step is not needed. The source code already guarantees the modules are tidy.
enfein
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.